Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add e2e for dynamicparams in app-router #794

Merged
merged 6 commits into from
Apr 3, 2025
Merged

add e2e for dynamicparams in app-router #794

merged 6 commits into from
Apr 3, 2025

Conversation

sommeeeer
Copy link
Contributor

E2E for dynamicParams in app-router:

  • dynamicParams set as true in /isr/dynamic-params-true/[id]
  • dynamicParams set as false in /isr/dynamic-params-false/[id]

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d3ecf90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sommeeeer sommeeeer requested a review from conico974 March 24, 2025 16:22
@sommeeeer sommeeeer requested a review from conico974 March 25, 2025 20:44
conico974
conico974 approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@conico974 conico974 merged commit 579ed15 into opennextjs:main Apr 3, 2025
1 check passed
@conico974 conico974 mentioned this pull request Apr 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sommeeeer @conico974